Support for custom skill

[Ahbolos]

 

Hello everyone, I would like to invite you to review some skill customs that I am making, it is for the epic core and orfen jewels in the first instance to try. 
The characteristic is that the jewels have been improved, but also when the player is attacked they can deliver a skillTrigger type buff that benefits the player. I will provide 3 examples. and I want to see if you see any basic errors, since I have been away from l2j for a long time.

I want to see if you find any errors in the lines, or if my approach is correct, because I want to apply it in general to Epic Jewelry and Armor Sets.

 

 

 

------------------------------------------------------------------------------------------------------------------------
PROTOTIPO 1 SKILL CHANCE POR GOLPÈ ENEMIGO
------------------------------------------------------------------------------------------------------------------------

    <skill id="3563" levels="1" name="Ring of Core">
        <!-- Increases posibility to reflect skills and physical damage to enemige, and have chance to feel to core power. -->
        <set name="target" val="SELF" />
        <set name="skillType" val="BUFF" />
        <set name="operateType" val="PASSIVE" />
        <set name="singleEffect" val="true" />
        <set name="triggeredId" val="35630" />
        <set name="triggeredLevel" val="1" />
        <for>
            <add order="0x40" stat="reflectDam" val="20" />
            <add order="0x40" stat="reflectSkillMagic" val="20" />
            <add order="0x40" stat="reflectSkillPhysic" val="20" />
        </for>
    </skill>
    <skill id="35630" levels="1" name="Core Power ">
        <!-- When receiving damage, there is 3% chance to get damage bonus P./ M. Def. decreasing skills for 5 sec. -->
        <set name="activationChance" val="3" />
        <set name="chanceType" val="ON_ATTACKED" />
        <set name="castRange" val="900" />
        <set name="effectRange" val="1400" />
        <set name="operateType" val="BUFF" />
        <set name="skillType" val="AGGDAMAGE" />
        <set name="target" val="SELF" />
        <set name="bestowed" val="true" />
        <for>
            <effect count="1" name="BestowSkill" time="5" val="0" />
            <mul order="0x30" stat="sDef" val="3.0" />  
            <mul order="0x30" stat="rShld" val="3.0" />
            <mul order="0x30" stat="pDef" val="3.0" />
            <mul order="0x30" stat="mDef" val="3.0" />
        </for>
    </skill>

------------------------------------------------------------------------------------------------------------------------
PROTOTIPO 2 SKILL CHANCE POR GOLPÈ ENEMIGO
------------------------------------------------------------------------------------------------------------------------

    <skill id="3563" levels="1" name="Ring of Core">
        <!-- Increases posibility to reflect skills and physical damage to enemige, and have chance to feel to core power. -->
        <set name="target" val="SELF" />
        <set name="skillType" val="BUFF" />
        <set name="operateType" val="CHANCE" />
        <set name="singleEffect" val="true" />
        <set name="triggeredId" val="35630" />
        <set name="triggeredLevel" val="1" />
        <set name="activationChance" val="3" />
        <set name="chanceType" val="ON_ATTACKED" />
        <for>
            <add order="0x40" stat="reflectDam" val="20" />
            <add order="0x40" stat="reflectSkillMagic" val="20" />
            <add order="0x40" stat="reflectSkillPhysic" val="20" />
            <add order="0x40" stat="accCombat" val="3" />
        </for>
    </skill>
    <skill id="35630" levels="1" name="Core Power ">
        <!-- When receiving damage, there is 3% chance to get damage bonus P./ M. Def. -->
        <set name="castRange" val="900" />
        <set name="effectRange" val="1400" />
        <set name="operateType" val="BUFF" />
        <set name="skillType" val="AGGDAMAGE" />
        <set name="target" val="SELF" />
        <set name="bestowed" val="true" />
        <for>
            <effect count="1" name="buff" time="1" val="0" noicon="1" />
            <mul order="0x30" stat="sDef" val="2.0" />  
            <mul order="0x30" stat="rShld" val="2.0" />
            <mul order="0x30" stat="pDef" val="2.0" />
            <mul order="0x30" stat="mDef" val="2.0" />
        </for>
    </skill>

-------------------------------------------------------------------------------------------------------------------------------
PROTOTIPO 3 SKILL CHANCE POR GOLPÈ ENEMIGO
-------------------------------------------------------------------------------------------------------------------------------

    <skill id="3560" levels="1" name="Earring of Orfen">
        <!-- Increases healing from heal spells and resistance to Bleed attack. -->
        <set name="target" val="SELF" />
        <set name="skillType" val="BUFF" />
        <set name="operateType" val="PASSIVE" />
        <set name="singleEffect" val="true" />
        <set name="triggeredId" val="35600" />
        <set name="triggeredLevel" val="1" />
        <for>
            <add order="0x40" stat="reflectDam" val="20" />
            <add order="0x40" stat="reflectSkillMagic" val="20" />
            <add order="0x40" stat="reflectSkillPhysic" val="20" />
        </for>
    </skill>
    <skill id="35600" levels="1" name="Orfen Power ">
        <!-- When receiving damage, there is 3% chance to get damage bonus heal all Clan, ally, party. -->
        <set name="castRange" val="900" />
        <set name="effectRange" val="1400" />
        <set name="operateType" val="BUFF" />
        <set name="skillType" val="HEAL" />
        <set name="target" val="SELF_ALLY_CLAN_PARTY" />
        <set name="bestowed" val="true" />
        <for>
            <effect count="7" name="HealOverTime" time="2" val="48" stackOrder="2 />
            <mul order="0x30" stat="regHp" val="4.5" />
            <mul order="0x30" stat="regMp" val="4.5" />
            <mul order="0x30" stat="regCp" val="4.5" />
        </for>
    </skill>